Skip to main content

Insecure functionality - Masking

Need​

Secure data masking

Context​

  • Usage of Scala for building scalable and functional applications
  • Usage of play.api.mvc for handling HTTP requests and responses in Play Framework

Description​

Non compliant code​

import play.api.mvc._

object HomeController extends Controller {
  def index = Action { implicit request =>
    val username = request.getQueryString("username")
    val password = request.getQueryString("password")

    Ok("Username: " + username + " Password: " + password)
  }
}

The above Scala code is a simple Play Framework controller that accepts HTTP requests and retrieves the "username" and "password" query parameters from the request. The confidentiality of the data is compromised as the system is not masking or encrypting the sensitive information (i.e., the username and password).

The index function retrieves the username and password from the request's query string and directly appends them to the HTTP response without any form of masking or encryption. This means that anyone who can intercept the HTTP response (e.g., via network sniffing or man-in-the-middle attacks) can easily read the username and password in plain text.

This is a serious security vulnerability because it exposes sensitive user information, which could be exploited by malicious users to gain unauthorized access to user accounts. It's especially dangerous if users are reusing passwords across multiple services, as gaining access to one password could potentially give an attacker access to multiple services.

Steps​

  • Use HTTPS to encrypt the communication between the client and the server.
  • Avoid logging sensitive information, such as passwords.
  • Implement input validation and sanitization to prevent malicious input.
  • Use secure session management to protect sensitive session data.
  • Implement access controls to restrict unauthorized access to sensitive information.
  • Implement data masking techniques to hide sensitive information in logs and responses.
  • Follow security best practices and guidelines provided by the Play framework.

Compliant code​

import play.api.mvc._
import play.api.Logger

object HomeController extends Controller {
  def index = Action { implicit request =>
    val username = request.getQueryString("username")
    val password = request.getQueryString("password")

    Logger.info("Username: " + username)
    Ok("Username: " + username)
  }
}

The original code was vulnerable because it was exposing sensitive information such as the user's password in the response. This is a serious security issue as it can lead to unauthorized access to the user's account.

The fixed code no longer includes the password in the response. Instead, it only logs the username for debugging purposes. The password is not logged to avoid exposing it in the logs.

In addition, it's recommended to use HTTPS to encrypt the communication between the client and the server. This will ensure that even if someone is able to intercept the communication, they won't be able to understand it.

Furthermore, it's important to implement input validation and sanitization to prevent malicious input. This can be done using Play framework's built-in validation features.

Secure session management should also be implemented to protect sensitive session data. This can be done using secure cookies or JWT tokens.

Access controls should be implemented to restrict unauthorized access to sensitive information. This can be done using role-based access control (RBAC) or access control lists (ACLs).

Finally, follow security best practices and guidelines provided by the Play framework to ensure the security of your application.

References​

Last updated on